-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flow): flow node manager #3954
Merged
fengjiachun
merged 3 commits into
GreptimeTeam:main
from
discord9:flow_p3_adapter_manager
May 16, 2024
Merged
feat(flow): flow node manager #3954
fengjiachun
merged 3 commits into
GreptimeTeam:main
from
discord9:flow_p3_adapter_manager
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3954 +/- ##
==========================================
- Coverage 85.64% 85.05% -0.59%
==========================================
Files 973 978 +5
Lines 167045 167873 +828
==========================================
- Hits 143073 142792 -281
- Misses 23972 25081 +1109 |
zhongzc
reviewed
May 16, 2024
zhongzc
reviewed
May 16, 2024
fengjiachun
reviewed
May 16, 2024
feat(flow): render src/sink feat(flow): flow node manager in standalone fix?: higher run freq chore: remove abunant error enum variant fix: run with higher freq if insert more chore: fix after rebase chore: typos
discord9
force-pushed
the
flow_p3_adapter_manager
branch
from
May 16, 2024 09:19
b917ffa
to
ece07ad
Compare
fengjiachun
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhongzc
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
Build flownode in standalone mode, allow flow create
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist